London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #958
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DamianDL
changed the title
This comment has been minimized.
This comment has been minimized.
DamianDL
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
DamianDL
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
DamianDL
added
the
Needs Review
DamianDL
changed the title
DamianDL
changed the title
DamianDL
added
Needs Review
jenny-alexander
added
Review in progress
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
Hi @DamianDL - I reviewed your PR. I see that a good attempt was made to complete some of the exercise requirements.
However, your webpage still needs quite a few adjustments in order to look like the wireframe in the exercise.
https://github.com/CodeYourFuture/Module-Onboarding/blob/main/Wireframe/wireframe.png
Looking at the wireframe, you can see that the primary structure of the page is to have 3 article cards. The first article card is found at the top of the page and spans most of the width of the page. The second and third articles are side by side underneath the first article card.
Can you review the wireframe again and attempt to make your webpage look as close to this as possible?
If you are having any difficulty understanding the exercise requirements, please be sure to ask questions on Slack. There are mentors and other trainees that can guide you along!
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
||
| <style> |
There was a problem hiding this comment.
Can you move all of the CSS styling into the style.css file? This ensures that the styling (CSS) is kept separate from the content (HTML) and makes it easier to read and maintain the code.
| } | ||
| } | ||
| </style> | ||
| </head> |
There was a problem hiding this comment.
This closing tag </head> doesn't match any opening tag. Perhaps it's a typo?
| } | ||
| </style> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
There is already a <body> element within the original index.html file. You are meant to add content to the existing <body> element.
A valid html file can only ever have one <body> element.
jenny-alexander
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Wireframe assignment completed
Questions
Please confirm that all elements of Wireframe assignment correctly completed as expected?